Network Type Indicator

Branch off 1.3 to add small changes before 1.4

Branch off 1.3, turned into 1.4 since it adds new features

This is a meta-item depending on bugs/features required to complete before releasing nettype 1.3

Next:  FS#215 

Re-do icons with bigger symbols

The manifest file can be modified to provide a back button (usually an arrow on the top left) when an activity is launched.

Use it for the settings and donations activities.

Submitted by Adjel

When roaming no network type is indicated.

Device: Nexus 5

NOTE: Not a bug report, misunderstanding on my part

AboutDialog, DonationsActivity and TogglePreference can be moved into a separate module since they can be used (or are already being used) verbatim by my other apps.

Requested on Google Play

It doesn’t make sense to load on boot if we won’t be displaying the notification.

Suggested by Adjel and Vel

Indicate connection status on notification icon

Reported on Google Play Store

Reported on Pie.

Reproducible on Lollipop and up.

Reported by David

The icon and main app can get out of sync on version 1.4

Probably related to FS#255.
1.4 used separate network listeners for notification and main app, with the main app always listening for signal strength changes (and notification doing so optionally).

Not reproducible. Example stack strace:

java.lang.NullPointerException
	at net.outlyer.nettype.MonitorService.b(MonitorService.java:316)
	at net.outlyer.nettype.MonitorService.a(MonitorService.java:292)
	at net.outlyer.nettype.l.onDataConnectionStateChanged(MonitorService.java:160)
	at android.telephony.PhoneStateListener$2.handleMessage(PhoneStateListener.java:339)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3683)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:875)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:633)
	at dalvik.system.NativeStart.main(Native Method)

Rare reports, not reproducible, but similar causes.

Example stack trace:

java.lang.RuntimeException: Unable to create service net.outlyer.nettype.MonitorService: java.lang.IllegalArgumentException: contentIntent required: pkg=net.outlyer.nettype id=1 notification=Notification(vibrate=null,sound=null,defaults=0x0,flags=0x2)
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:1974)
	at android.app.ActivityThread.access$2500(ActivityThread.java:121)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:994)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3714)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:864)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:622)
	at dalvik.system.NativeStart.main(Native Method)
	Caused by: java.lang.IllegalArgumentException: contentIntent required: pkg=net.outlyer.nettype id=1 notification=Notification(vibrate=null,sound=null,defaults=0x0,flags=0x2)
	at android.os.Parcel.readException(Parcel.java:1326)
	at android.os.Parcel.readException(Parcel.java:1276)
	at android.app.INotificationManager$Stub$Proxy.enqueueNotificationWithTag(INotificationManager.java:274)
	at android.app.NotificationManager.notify(NotificationManager.java:111)
	at android.app.NotificationManager.notify(NotificationManager.java:91)
	at net.outlyer.nettype.MonitorService.b(MonitorService.java:201)
	at net.outlyer.nettype.MonitorService.onCreate(MonitorService.java:80)
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:1964)
	... 10 more

Should switch to a multi-apk release, where older versions of Android (pre-ICS) will only get bugfixes.

This setting is shown regardless of version but it has no effect on older Androids since they don’t support notification actions.

Submitted by Tom

See also  FS#251 

Display signal strength in dbm/asu in the status bar

Submitted by Allan

See also  FS#221 

Display signal strength in dbm/asu in the notification

Submitted by Tom

No need for description

Reported by Marcel Bokhorst

Starting with Lollipop notifications are shown in the lock screen expanded, and their
contents will be hidden if public visibility isn’t set explicitly.

See FS#356

More modern UI elements. Only supported in Android 4.0 (API level 14) and up.

Nowadays it’s common practice to have apps with light themes by default

Currently, pre-Honeycomb, the theme is based on the old default theme, post-Honeycomb it’s based on Holo.

However starting with ICS there’s also a DeviceDefault theme that makes the app look more integrated (i.e. it looks like Holo on older devices, and like Material on newer ones).

To ease propagating changes to all densities

Reported by Simon Howard 18/12/2016 on Google Play

Issue with auto start on boot I’ve had this app for some time now, but it will not auto start on boot on my current phone (Galaxy S5, Marshmallow 6.01)

Galaxy S5 (klte) / Marshmallow / r14034