Network Type Indicator

No need for description

Should switch to a multi-apk release, where older versions of Android (pre-ICS) will only get bugfixes.

Reported by David

The icon and main app can get out of sync on version 1.4

Probably related to FS#255.
1.4 used separate network listeners for notification and main app, with the main app always listening for signal strength changes (and notification doing so optionally).

Rare reports, not reproducible, but similar causes.

Example stack trace:

java.lang.RuntimeException: Unable to create service net.outlyer.nettype.MonitorService: java.lang.IllegalArgumentException: contentIntent required: pkg=net.outlyer.nettype id=1 notification=Notification(vibrate=null,sound=null,defaults=0x0,flags=0x2)
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:1974)
	at android.app.ActivityThread.access$2500(ActivityThread.java:121)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:994)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3714)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:864)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:622)
	at dalvik.system.NativeStart.main(Native Method)
	Caused by: java.lang.IllegalArgumentException: contentIntent required: pkg=net.outlyer.nettype id=1 notification=Notification(vibrate=null,sound=null,defaults=0x0,flags=0x2)
	at android.os.Parcel.readException(Parcel.java:1326)
	at android.os.Parcel.readException(Parcel.java:1276)
	at android.app.INotificationManager$Stub$Proxy.enqueueNotificationWithTag(INotificationManager.java:274)
	at android.app.NotificationManager.notify(NotificationManager.java:111)
	at android.app.NotificationManager.notify(NotificationManager.java:91)
	at net.outlyer.nettype.MonitorService.b(MonitorService.java:201)
	at net.outlyer.nettype.MonitorService.onCreate(MonitorService.java:80)
	at android.app.ActivityThread.handleCreateService(ActivityThread.java:1964)
	... 10 more

No need for description

Not reproducible. Example stack strace:

java.lang.NullPointerException
	at net.outlyer.nettype.MonitorService.b(MonitorService.java:316)
	at net.outlyer.nettype.MonitorService.a(MonitorService.java:292)
	at net.outlyer.nettype.l.onDataConnectionStateChanged(MonitorService.java:160)
	at android.telephony.PhoneStateListener$2.handleMessage(PhoneStateListener.java:339)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loop(Looper.java:130)
	at android.app.ActivityThread.main(ActivityThread.java:3683)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:507)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:875)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:633)
	at dalvik.system.NativeStart.main(Native Method)

Initially fixes (believed to be) only required for older devices.
Now also seen on newer devices

See also  FS#261 

Received reports on newer devices, sync changes from older droids’ branch

Feedback from Hassan Ramli:

Hassan Ramli 24/10/2014 11:58

I like it better when there's no option to open network setting and disable
notification at the status bar drawer

Feedback from Evgenij Gerasimov:

Evgenij Gerasimov 28/10/2014 7:08

Useful app but New submenu ('Network' and 'Remove notification' buttons), right under
regular notification is not a thing I'd like to see everytime I open a notification area.
Mainly because it's useless at all and takes too much place.
There should be an option in the app that would allow not to show this submenu, I think.

Add as a configurable option

Affects new droids and old droids branches.

Has never been reported in the developer console.

This is a meta-item depending on bugs/features required to complete before releasing nettype 1.4.4

More modern UI elements. Only supported in Android 4.0 (API level 14) and up.

Apart from DC-HSPA+ ( FS#238 ) there’s three extra types: GSM, TD-SCDMA and IWLAN.

Lollipop’s new handling of ongoing notifications makes Nettype’s notification to stay on the lockscreen.

Brought up by Andrey Simakov and Theos Greg on Google Play.

Reported by Marcel Bokhorst

Starting with Lollipop notifications are shown in the lock screen expanded, and their
contents will be hidden if public visibility isn’t set explicitly.

Currently, pre-Honeycomb, the theme is based on the old default theme, post-Honeycomb it’s based on Holo.

However starting with ICS there’s also a DeviceDefault theme that makes the app look more integrated (i.e. it looks like Holo on older devices, and like Material on newer ones).

It doesn’t make sense to load on boot if we won’t be displaying the notification.

Nowadays it’s common practice to have apps with light themes by default

Should be very careful to stay within Google’s AUP though

Events are handled in different groups, it makes sense to handle them in as few listeners as possible (where they can be logically grouped)

This setting is shown regardless of version but it has no effect on older Androids since they don’t support notification actions.

Requested on Google Play

This should prevent task killers from reaping it as easily

Starting with Marshmallow (API level 23, Android 6.0) READ_PHONE_STATE is considered a dangerous permission (and as a result it can be revoked by the user at any time) but at the same time it is no longer required to check connection status.

Should restrict it to old API levels (NOTE the API documentation don’t mention this requirement anymore, but old devices DO require it).

The manifest file can be modified to provide a back button (usually an arrow on the top left) when an activity is launched.

Use it for the settings and donations activities.